Minimap Canvas Mode Fixes & Compartment Proxy Rewrite#80
Open
Larsmara wants to merge 6 commits intoMoONSHO7:mainfrom
Open
Minimap Canvas Mode Fixes & Compartment Proxy Rewrite#80Larsmara wants to merge 6 commits intoMoONSHO7:mainfrom
Larsmara wants to merge 6 commits intoMoONSHO7:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compartment flyout — Rewrote from reparenting real LibDBIcon buttons to using proxy icon buttons. Reparented buttons render dark due to inherent texture/overlay issues in LibDBIcon. Proxy buttons create clean icon textures and forward clicks/tooltips via dataObject. Also replaced the fullscreen click-away overlay (which blocked clicks on the flyout buttons) with OnUpdate mouse-leave polling.
Difficulty icon (canvas) — Background/Border textures now respect the DifficultyShowBackground toggle instead of always rendering. The "25" group-size placeholder label is anchored to the skull texture itself rather than the whole iconVisual frame, so it sits directly beneath the icon.
DifficultyDisplay dropdown — Switching between Icon and Text always showed "Icon" because canvasDialog:Open() calls Transaction:Begin() which wipes pending settings. Fixed by persisting the value via plugin:SetSetting() before the dialog reopens.